fix: update bucket policy to work with permission boundaries #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontirun
changed the title
|
fixes #532 |
dontirun
approved these changes
Nov 3, 2022
|
One check is failing, but not sure why. Should I merge main branch into my branch and push again? |
|
@vmarinescu let's try that. Otherwise I think you may need to grant permissions on the branch for workflows and maintainers to push to it |
jpduckwo
pushed a commit
to jpduckwo/cdk-serverless-clamscan
that referenced
this pull request
Sep 4, 2023
…#637) Solves awslabs#635 The aim of this PR is to update the bucket policy so that it does not prevent downloading of the object in some cases. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #635
The aim of this PR is to update the bucket policy so that it does not prevent downloading of the object in some cases.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license