fix(cli): Conform python and java package names to language standards (no hyphens) #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: campionfellin <campionfellin@gmail.com>
… (no hyphens) Fixes: cdk8s-team#274 Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
|
Looks like I missed updating the snapshots in the unit tests. Will do that tomorrow! |
iliapolo
reviewed
Aug 4, 2020
iliapolo
previously approved these changes
Aug 4, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
Signed-off-by: campionfellin <campionfellin@gmail.com>
iliapolo
approved these changes
Aug 5, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With new changes in
jsii-srcmak, it throws an Error when trying to use a package or moduleName with a hyphen (see commit: cdklabs/jsii-srcmak@766de96)This is the other side of that and fixes that issue by replacing
-with_.Tested by changing the
version.yamlin the python CRD example to use a hyphen in the name. It successfully comes in as an underscore and is able to be imported.Fixes #274
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license