Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add benchmark tool #1057

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: add benchmark tool #1057

wants to merge 3 commits into from

Conversation

dengmingtong
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Summary

(describe what this merge request does)

Implementation highlights

(describe how the merge request does for feature changes, share the RFC link if it has)

Test checklist

  • add new test cases
  • all code changes are covered by unit tests
  • end-to-end tests
    • deploy web console with CloudFront + S3 + API gateway
    • deploy web console within VPC
    • deploy ingestion server
      • with MSK sink
      • with KDS sink
      • with S3 sink
    • deploy data processing
    • deploy data modeling
      • new Redshift Serverless
      • provisioned Redshift
      • Athena
    • deploy with reporting
    • streaming ingestion
      • with Redshift Serverless
      • with provisioned Redshift

Is it a breaking change

  • add parameters without default value in stack
  • introduce new service permission in stack
  • introduce new top level stack module

Miscellaneous

  • introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

@dengmingtong dengmingtong self-assigned this Apr 14, 2024
@github-actions GitHub Actions
Copy link

Etl common library's test coverage

Overall Project 93.79% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Streaming ingestion flink application's test coverage

Overall Project 94.57% 🍏

There is no coverage information present for the Files changed

@dengmingtong dengmingtong changed the title chore: add performance tool draft: add performance tool Apr 14, 2024
@dengmingtong dengmingtong changed the title draft: add performance tool chore: add performance tool Apr 14, 2024
@github-actions GitHub Actions
Copy link

Data Pipeline spark application's test coverage

Overall Project 98.45% 🍏

There is no coverage information present for the Files changed

zxkane
zxkane requested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@zxkane zxkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • move a separate folder like benchmark
  • refacor to reuse existing standalone generator

zxkane
zxkane requested changes Apr 15, 2024
View reviewed changes
examples/standalone-data-generator/requirements.txt
@@ -0,0 +1 @@
requests~=2.28.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

@github-actions GitHub Actions
Copy link

Etl common library's test coverage

Overall Project 92.91% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Streaming ingestion flink application's test coverage

Overall Project 94.57% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Data Pipeline spark application's test coverage

Overall Project 98.4% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Etl common library's test coverage

Overall Project 92.54% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Streaming ingestion flink application's test coverage

Overall Project 94.57% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Data Pipeline spark application's test coverage

Overall Project 98.4% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
src 100% 82% ✔
src.analytics 100% 100% ✔
src.analytics.lambdas 95% 89% ✔
src.analytics.lambdas.clear-expired-events-workflow 100% 100% ✔
src.analytics.lambdas.custom-resource 96% 87% ✔
src.analytics.lambdas.load-data-workflow 99% 90% ✔
src.analytics.lambdas.refresh-materialized-views-workflow 98% 90% ✔
src.analytics.lambdas.scan-metadata-workflow 97% 89% ✔
src.analytics.lambdas.sql-execution-sfn 93% 60% ✔
src.analytics.lambdas.user-segments-workflow 96% 77% ✔
src.analytics.private 100% 92% ✔
src.analytics.private.athena 100% 100% ✔
src.analytics.private.segments 100% 100% ✔
src.base-lib.src 100% 100% ✔
src.base-lib.src.auth 89% 65% ✔
src.base-lib.src.common 97% 73% ✔
src.base-lib.src.constant 100% 100% ✔
src.base-lib.src.model 100% 100% ✔
src.common 98% 80% ✔
src.common.lambda 97% 86% ✔
src.control-plane 97% 72% ✔
src.control-plane.auth 93% 12% ✔
src.control-plane.backend 100% 88% ✔
src.control-plane.backend.lambda.api 97% 33% ✔
src.control-plane.backend.lambda.api.common 92% 81% ✔
src.control-plane.backend.lambda.api.middle-ware 89% 83% ✔
src.control-plane.backend.lambda.api.model 95% 56% ✔
src.control-plane.backend.lambda.api.router 98% 97% ✔
src.control-plane.backend.lambda.api.service 84% 69% ✔
src.control-plane.backend.lambda.api.service.quicksight 91% 83% ✔
src.control-plane.backend.lambda.api.service.segments 95% 77% ✔
src.control-plane.backend.lambda.api.store.aws 87% 55% ✔
src.control-plane.backend.lambda.api.store.dynamodb 90% 81% ✔
src.control-plane.backend.lambda.api.test.api 98% 81% ✔
src.control-plane.backend.lambda.api.test.api.segments 100% 100% ✔
src.control-plane.backend.lambda.batch-insert-ddb 94% 83% ✔
src.control-plane.backend.lambda.listen-stack-status 83% 49% ✔
src.control-plane.backend.lambda.listen-state-status 89% 40% ✔
src.control-plane.backend.lambda.sfn-action 84% 47% ✔
src.control-plane.backend.lambda.sfn-workflow 70% 57% ➖
src.control-plane.backend.layer.lambda-web-adapter 100% 20% ✔
src.control-plane.private 100% 100% ✔
src.data-pipeline 100% 92% ✔
src.data-pipeline.lambda.copy-assets 97% 90% ✔
src.data-pipeline.lambda.emr-job-state-listener 96% 90% ✔
src.data-pipeline.lambda.emr-job-submitter 100% 78% ✔
src.data-pipeline.lambda.emr-serverless-app 100% 90% ✔
src.data-pipeline.lambda.partition-syncer 98% 89% ✔
src.data-pipeline.tables 100% 100% ✔
src.data-pipeline.utils 100% 100% ✔
src.ingestion-server.custom-resource 100% 100% ✔
src.ingestion-server.custom-resource.delete-ecs-cluster 98% 90% ✔
src.ingestion-server.custom-resource.update-alb-rules 100% 78% ✔
src.ingestion-server.kafka-s3-connector 100% 100% ✔
src.ingestion-server.kafka-s3-connector.custom-resource.kafka-s3-sink-connector 96% 82% ✔
src.ingestion-server.kinesis-data-stream 100% 100% ✔
src.ingestion-server.kinesis-data-stream.kinesis-to-s3-lambda 100% 100% ✔
src.ingestion-server.kinesis-data-stream.private 100% 100% ✔
src.ingestion-server.server 98% 89% ✔
src.ingestion-server.server-v2 100% 79% ✔
src.ingestion-server.server-v2.private 100% 82% ✔
src.ingestion-server.server.private 100% 89% ✔
src.metrics 100% 100% ✔
src.metrics.custom-resource.add-sns-subscription 95% 86% ✔
src.metrics.custom-resource.get-interval 99% 97% ✔
src.metrics.custom-resource.put-dashboard 97% 84% ✔
src.metrics.custom-resource.set-metrics-widgets 98% 93% ✔
src.private 97% 72% ✔
src.reporting 100% 75% ✔
src.reporting.lambda.custom-resource.quicksight 95% 84% ✔
src.reporting.private 90% 56% ✔
src.streaming-ingestion 100% 100% ✔
src.streaming-ingestion.lambdas.custom-resource 86% 63% ✔
src.streaming-ingestion.private 99% 89% ✔
src.streaming-ingestion.redshift 100% 100% ✔
test 96% 83% ✔
test.common 93% 100% ✔
test.control-plane 97% 64% ✔
test.ingestion-server.server 97% 88% ✔
Summary 96% (76631 / 79812) 75% (6306 / 8368) ✔

Minimum allowed line rate is 60%

@zxkane zxkane changed the title chore: add performance tool chore: add benchmark tool May 10, 2024
@zxkane zxkane marked this pull request as draft May 10, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxkane zxkane zxkane requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@dengmingtong dengmingtong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dengmingtong @zxkane