Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding terraform bootstrap for fully private deployment #200

Merged
merged 45 commits into from
Jul 24, 2024

Conversation

edgarsilva948
Copy link
Collaborator

What does this PR do?

This PR introduces a Terraform bootstrap configuration for fully private deployments. The update provides a secure and isolated setup by ensuring all resources are configured without public internet access.

Motivation

The need for enhanced security and compliance in sensitive environments motivated the development of this fully private deployment example. By leveraging a fully isolated infrastructure, users can significantly mitigate exposure to external threats.

More

  • Tested: Yes, I have tested this PR using my local setup. (Details of the test evidence are provided under Additional Notes.)
  • Examples Added: Yes, I have added a new example under examples to support my PR.
  • Documentation Updated: Yes, I have updated the documentation to reflect this feature.
  • Linked Issue/Feature Request: Yes, I have linked to an issue or feature request where applicable. (Include the link if available.)

Note:

  • Not all PRs require adding examples and updating documentation.
  • We prefer small, well-tested pull requests. Please ensure your PR is self-contained and commits are squashed where appropriate.

For Moderators

  • E2E Test: Has the E2E test been successfully completed before merging?

Additional Notes

N/A

bootstrap/terraform-fully-private/README.md Show resolved Hide resolved
bootstrap/terraform-fully-private/README.md Outdated Show resolved Hide resolved
bootstrap/terraform-fully-private/README.md Outdated Show resolved Hide resolved
bootstrap/terraform-fully-private/README.md Show resolved Hide resolved
bootstrap/terraform-fully-private/README.md Outdated Show resolved Hide resolved
@candonov
Copy link
Contributor

@edgarsilva948 How does the IAM family provider talk to the IAM API? We cannot create a vpc endpoint for iam because the API is global.

Copy link
Contributor

@candonov candonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@candonov candonov merged commit c56d066 into main Jul 24, 2024
2 checks passed
@candonov candonov deleted the feat/terraform-bootstrap-fully-private branch July 24, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants