-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adding terraform bootstrap for fully private deployment #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
candonov
reviewed
Jun 25, 2024
candonov
reviewed
Jun 25, 2024
bootstrap/terraform-fully-private/providers/upjet-aws/provider.yaml
Outdated
Show resolved
Hide resolved
@edgarsilva948 How does the IAM family provider talk to the IAM API? We cannot create a vpc endpoint for iam because the API is global. |
candonov
reviewed
Jun 25, 2024
bootstrap/terraform-fully-private/scripts/push-images-to-ecr.sh
Outdated
Show resolved
Hide resolved
candonov
reviewed
Jun 25, 2024
… by removing aws_
candonov
reviewed
Jul 5, 2024
candonov
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a Terraform bootstrap configuration for fully private deployments. The update provides a secure and isolated setup by ensuring all resources are configured without public internet access.
Motivation
The need for enhanced security and compliance in sensitive environments motivated the development of this fully private deployment example. By leveraging a fully isolated infrastructure, users can significantly mitigate exposure to external threats.
More
Note:
For Moderators
Additional Notes
N/A