Skip to content

Commit

Permalink
damo_schemes: Ignore error of turning DAMON off in cleanup_exit()
Browse files Browse the repository at this point in the history
As the comment says, we can ignore turn_damon_off() error in
damo-schemes cleanup, similar to that of damo_record.  However, it is
not really ignoring it but prints message.  It makes people confused[1].
Ignore the error in real.

[1] #53

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
  • Loading branch information
sjp38 committed Jun 17, 2023
1 parent 9bd6786 commit 2ab78d0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions damo_schemes.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@

def cleanup_exit(exit_code):
# ignore returning error, as kdamonds may already finished
err = _damon.turn_damon_off(kdamonds_idxs)
if err:
print('failed to turn damon off (%s)' % err)
_damon.turn_damon_off(kdamonds_idxs)
err = _damon.stage_kdamonds(orig_kdamonds)
if err:
print('failed restoring previous kdamonds setup (%s)' % err)
Expand Down

0 comments on commit 2ab78d0

Please sign in to comment.