feat: Updates to the Ray blueprint #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askulkarni2
temporarily deployed
to
DoEKS Test
GitHub Actions
Inactive
askulkarni2
temporarily deployed
to
DoEKS Test
GitHub Actions
Inactive
askulkarni2
temporarily deployed
to
DoEKS Test
GitHub Actions
Inactive
askulkarni2
temporarily deployed
to
DoEKS Test
GitHub Actions
Inactive
askulkarni2
temporarily deployed
to
DoEKS Test
GitHub Actions
Inactive
askulkarni2
temporarily deployed
to
DoEKS Test
GitHub Actions
Inactive
askulkarni2
temporarily deployed
to
DoEKS Test
GitHub Actions
Inactive
askulkarni2
temporarily deployed
to
DoEKS Test
GitHub Actions
Inactive
askulkarni2
temporarily deployed
to
DoEKS Test
GitHub Actions
Inactive
vara-bonthu
reviewed
Feb 20, 2023
4 tasks
vara-bonthu
reviewed
Feb 26, 2023
vara-bonthu
reviewed
Mar 5, 2023
vara-bonthu
reviewed
Mar 21, 2023
Comment on lines
+119
to
+145
| cluster_addons = { | ||
| coredns = { | ||
| most_recent = true | ||
| } | ||
| kube-proxy = { | ||
| most_recent = true | ||
| } | ||
| vpc-cni = { | ||
| # The VPC CNI addon should be deployed before compute to ensure | ||
| # the addon is configured before data plane compute resources are created | ||
| # See README for further details | ||
| before_compute = true | ||
| most_recent = true # To ensure access to the latest settings provided | ||
| preserve = true | ||
| configuration_values = jsonencode({ | ||
| env = { | ||
| # Reference https://aws.github.io/aws-eks-best-practices/reliability/docs/networkmanagement/#cni-custom-networking | ||
| AWS_VPC_K8S_CNI_CUSTOM_NETWORK_CFG = "true" | ||
| ENI_CONFIG_LABEL_DEF = "topology.kubernetes.io/zone" | ||
|
|
||
| # Reference docs https://docs.aws.amazon.com/eks/latest/userguide/cni-increase-ip-addresses.html | ||
| ENABLE_PREFIX_DELEGATION = "true" | ||
| WARM_PREFIX_TARGET = "1" | ||
| } | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
@askulkarni2 Let's move this to Kubernetes add-ons module in the next revision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
The current example for Ray under AI/ML is outdated and uses some of the legacy code. This PR updates the example to incorporate the new helm charts for kuberay-operator. The example also takes into account the upcoming changes in the v5 of EKS Blueprints and hence uses upstream EKS module for cluster and node group creation.
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes