Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup scripts added #126

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Cleanup scripts added #126

merged 2 commits into from
Mar 7, 2023

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Mar 7, 2023

What does this PR do?

馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Cleanup script added for few blueprints
  • Workshop code with cleanup script added

Closes #122 #117

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR to add a new Add-on for Terraform EKS Blueprints repo (if applicable)
  • Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu requested a review from a team as a code owner March 7, 2023 15:54
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test March 7, 2023 15:54 — with GitHub Actions Inactive
Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion I have is to use

set -o errexit
set -o pipefail

Just to make sure they fail early when more logic is needed in the future.

@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test March 7, 2023 17:52 — with GitHub Actions Inactive
@vara-bonthu vara-bonthu merged commit 4a160b4 into main Mar 7, 2023
@vara-bonthu vara-bonthu deleted the workshop-docs branch March 7, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add clean up scripts
2 participants