Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

added preserve field to true to avoid destroy issues #144

Merged
merged 6 commits into from
Mar 20, 2023
Merged

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Mar 20, 2023

What does this PR do?

馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Added preserve=true for key managed add-ons to avoid destroy issues
  • Updated Install and cleanup shell scripts with stuck terminating namespace
  • pre-commit formatting

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR to add a new Add-on for Terraform EKS Blueprints repo (if applicable)
  • Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu requested a review from a team as a code owner March 20, 2023 20:08
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test March 20, 2023 20:08 — with GitHub Actions Inactive
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test March 20, 2023 20:11 — with GitHub Actions Inactive
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test March 20, 2023 20:35 — with GitHub Actions Inactive
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test March 20, 2023 20:38 — with GitHub Actions Inactive
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test March 20, 2023 21:00 — with GitHub Actions Inactive
@vara-bonthu vara-bonthu merged commit 8bf3ef4 into main Mar 20, 2023
@vara-bonthu vara-bonthu deleted the destroy-fix branch March 20, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants