Kafka on EKS - EKS Bluprints V5 Mitigation #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vara-bonthu
reviewed
Apr 2, 2023
| resource "aws_eks_addon" "vpc_cni" { | ||
| cluster_name = module.eks.cluster_name | ||
| addon_name = "vpc-cni" | ||
| service_account_role_arn = module.vpc_cni_irsa.iam_role_arn |
There was a problem hiding this comment.
add preserve=true to ensure VPC CNI is not fully deleted before the EKS Cluster. VPC CNI sometimes required to cleanup the existing add-ons
vara-bonthu
reviewed
Apr 2, 2023
There was a problem hiding this comment.
Thanks @AlyIbrahim ! PR Looks good. few minor comment.
In addition.
1/ Please add install and cleanup scripts like other blueprints
2/ Raise an issue to create a Architecture diagram for this pattern
Thanks 馃憤馃徏
|
|
||
| resource "aws_eks_addon" "coredns" { | ||
| cluster_name = module.eks.cluster_name | ||
| addon_name = "coredns" |
|
|
||
| resource "aws_eks_addon" "kube_proxy" { | ||
| cluster_name = module.eks.cluster_name | ||
| addon_name = "kube-proxy" |
streaming/kafka/addons.tf
Outdated
|
|
||
| #--------------------------------------------------------------- | ||
| # Cluster Autoscaler | ||
| #--------------------------------------------------------------- | ||
|
|
| @@ -169,85 +114,115 @@ provisioner: ebs.csi.aws.com | |||
| reclaimPolicy: Delete | |||
| volumeBindingMode: WaitForFirstConsumer | |||
| YAML | |||
| } | |||
There was a problem hiding this comment.
Add a dependency to on EKS module for this storage class resource
streaming/kafka/addons.tf
Outdated
Comment on lines
196
to
197
| yaml_body = file("./monitoring-manifests/podmonitor-cluster-operator-metrics.yml") | ||
| depends_on = [kubectl_manifest.kafka_namespace] |
There was a problem hiding this comment.
nit: formatting. add two spaces. Pre-commit didn't pickup thisone?
same for all the resources below
streaming/kafka/main.tf
Outdated
Comment on lines
52
to
68
| # ingress_fsx1 = { | ||
| # description = "Allows Lustre traffic between Lustre clients" | ||
| # cidr_blocks = module.vpc.private_subnets_cidr_blocks | ||
| # from_port = 1021 | ||
| # to_port = 1023 | ||
| # protocol = "tcp" | ||
| # type = "ingress" | ||
| # } | ||
|
|
||
| # ingress_fsx2 = { | ||
| # description = "Allows Lustre traffic between Lustre clients" | ||
| # cidr_blocks = module.vpc.private_subnets_cidr_blocks | ||
| # from_port = 988 | ||
| # to_port = 988 | ||
| # protocol = "tcp" | ||
| # type = "ingress" | ||
| # } |
There was a problem hiding this comment.
remove the commented lines
vara-bonthu
approved these changes
Jun 1, 2023
vara-bonthu
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Updating Kafka-on-EKS patterns by:
Motivation
EKS Blueprints v5 upgrade
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes