Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed broken link in spark observability module #214

Merged
merged 2 commits into from
May 30, 2023
Merged

fixed broken link in spark observability module #214

merged 2 commits into from
May 30, 2023

Conversation

lusoal
Copy link
Contributor

@lusoal lusoal commented May 30, 2023

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Fixing broken link in Spark Observability model

Motivation

Improve hands-on labs for folks joining TFC area of focus

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

None

@lusoal lusoal requested a review from a team as a code owner May 30, 2023 15:33
@lusoal lusoal temporarily deployed to DoEKS Test May 30, 2023 15:33 — with GitHub Actions Inactive
@lusoal lusoal temporarily deployed to DoEKS Test May 30, 2023 18:14 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 merged commit 3499e9a into awslabs:main May 30, 2023
25 checks passed
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. @lusoal One minor issue. You can raise another PR for this.

```bash
kubectl port-forward -n=spark <SPARK_DRIVER_NAME> 4040:4040
kubectl port-forward po/taxi-trip 4040:4040 -nspark-team-a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space is missing after -n

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works anyways, but I'll fix it, thanks Vara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants