Feat/emr eks spark operator #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vara-bonthu
requested changes
Jun 11, 2023
There was a problem hiding this comment.
@lmouhib Thanks for raising the PR for this new feature. We don't need a new blueprint for this pattern. We can use the existing emr-eks-karpenter blueprint and introduce a new variable for deploying emr-spark-operator add-on.
- Add a new variable to deploy
emr-spark-operatoradd-on - Add this new add-on under
workshop/modules/terraform-aws-eks-data-addons - Add new example under
analytics/terraform/emr-eks-karpenter/examples/emr-spark-operatorandemr-spark-submitetc. - You can have a dedicated Website doc similar to what you did in the PR
lmouhib
force-pushed
the
feat/emr-eks-spark-operator
branch
from
5c3d66c
to
4698724
Compare
|
@vara-bonthu I applied the changes requested |
vara-bonthu
reviewed
Jun 14, 2023
| )) | ||
| } | ||
|
|
||
| resource "helm_release" "emr_spark_operator" { |
There was a problem hiding this comment.
You need to use all the values that comes with helm release. Use the other helm release example.
| cpu: 100m | ||
| memory: 512Mi | ||
|
|
||
| # batchScheduler: |
There was a problem hiding this comment.
Remove the commented lines
| # -- Webhook service port | ||
| port: 8080 | ||
|
|
||
| emrContainers: |
There was a problem hiding this comment.
Set only this value in this module and ignore the other values as those are the default
vara-bonthu
reviewed
Jun 19, 2023
| @@ -31,6 +31,10 @@ locals { | |||
| grafana_repository = "https://grafana.github.io/helm-charts" | |||
| grafana_version = "6.52.4" | |||
|
|
|||
| emr_spark_operator_name = "spark-operator" | |||
| emr_spark_operator_version = "1.1.26-amzn-1" | |||
| emr_spark_operator_namespace = "spark-operator" | |||
There was a problem hiding this comment.
change this to emr-spark-operator
vara-bonthu
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a blueprint to use Spark Operator with EMR on EKS.
馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
Recently launched feature by emr on eks
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes