Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyterhub on EKS #228

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Jupyterhub on EKS #228

merged 9 commits into from
Jul 4, 2023

Conversation

rajarshighosal
Copy link
Contributor

@rajarshighosal rajarshighosal commented Jun 20, 2023 •
edited

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Jupyterhub on EKS
Cognito integration
Shared file storage for users

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@rajarshighosal rajarshighosal temporarily deployed to DoEKS Test June 20, 2023 21:52 — with GitHub Actions Inactive
bryantbiggs
bryantbiggs reviewed Jun 22, 2023
View reviewed changes
ai-ml/jupyterhub/main.tf
# Note: This can further restricted to specific required for each Add-on and your application
#---------------------------------------
# Extend cluster security group rules
cluster_security_group_additional_rules = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need all of this opened up? can we open up only what is necessary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajarshighosal Let's test this for all add-ons and open only required ports in the next PR

bryantbiggs
bryantbiggs reviewed Jun 22, 2023
View reviewed changes
ai-ml/jupyterhub/main.tf Outdated
NodeGroupType = "core"
}

tags = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have local tags, but they aren't added here or to the other resources - should they be added/merged?

bryantbiggs
bryantbiggs reviewed Jun 22, 2023
View reviewed changes
ai-ml/jupyterhub/variables.tf Outdated
# Routable Public subnets with NAT Gateway and Internet Gateway
variable "public_subnets" {
description = "Public Subnets CIDRs. 62 IPs per Subnet/AZ"
default = ["10.1.0.0/26", "10.1.0.64/26"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting a VPC CIDR and then subnet CIDRs like this could be problematic - better to calculate based off the VPC CIDR. For example, what if someone changes just the VPC CIDR and not the rest of the values?

@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test June 23, 2023 14:00 — with GitHub Actions Inactive
@rajarshighosal rajarshighosal temporarily deployed to DoEKS Test June 27, 2023 23:20 — with GitHub Actions Inactive
@rajarshighosal rajarshighosal temporarily deployed to DoEKS Test June 27, 2023 23:31 — with GitHub Actions Inactive
@rajarshighosal rajarshighosal temporarily deployed to DoEKS Test June 28, 2023 14:18 — with GitHub Actions Inactive
@rajarshighosal rajarshighosal temporarily deployed to DoEKS Test June 28, 2023 16:15 — with GitHub Actions Inactive
vara-bonthu
vara-bonthu approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 I believe this is good to go now.
@rajarshighosal Let's address the remaining comments from Bryant on the next PR.

@rajarshighosal rajarshighosal temporarily deployed to DoEKS Test June 28, 2023 19:47 — with GitHub Actions Inactive
@vara-bonthu vara-bonthu self-requested a review June 28, 2023 19:57
vara-bonthu
vara-bonthu reviewed Jun 28, 2023
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few comments

ai-ml/jupyterhub/addons.tf Show resolved Hide resolved
ai-ml/jupyterhub/addons.tf Show resolved Hide resolved
ai-ml/jupyterhub/addons.tf Show resolved Hide resolved
ai-ml/jupyterhub/addons.tf Outdated Show resolved Hide resolved
ai-ml/jupyterhub/addons.tf Show resolved Hide resolved
ai-ml/jupyterhub/install.sh Outdated Show resolved Hide resolved
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test July 2, 2023 19:32 — with GitHub Actions Inactive
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test July 3, 2023 14:13 — with GitHub Actions Inactive
@rajarshighosal rajarshighosal temporarily deployed to DoEKS Test July 4, 2023 04:23 — with GitHub Actions Inactive
@rajarshighosal rajarshighosal temporarily deployed to DoEKS Test July 4, 2023 05:55 — with GitHub Actions Inactive
@rajarshighosal rajarshighosal temporarily deployed to DoEKS Test July 4, 2023 05:57 — with GitHub Actions Inactive
@rajarshighosal rajarshighosal temporarily deployed to DoEKS Test July 4, 2023 06:12 — with GitHub Actions Inactive
vara-bonthu
vara-bonthu approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vara-bonthu vara-bonthu merged commit 14835f3 into awslabs:main Jul 4, 2023
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs left review comments

@vara-bonthu vara-bonthu vara-bonthu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rajarshighosal @bryantbiggs @vara-bonthu