chore: Remove VPC CNI IRSA role; utilize permissions provided on EC2 node IAM role #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
commented
Jul 11, 2023
| @@ -137,41 +137,3 @@ This will remove the finalizers on the namespace. | |||
| NAMESPACE=<namespace> | |||
| kubectl get namespace $NAMESPACE -o json | sed 's/"kubernetes"//' | kubectl replace --raw "/api/v1/namespaces/$NAMESPACE/finalize" -f - | |||
| ``` | |||
|
|
|||
| ## Resolve Conflicts error while deploying VPC CNI managed add-on | |||
There was a problem hiding this comment.
Removed this since this OVERWRITE is the default for nearly all modules - let me know if we still want to retain this though
bryantbiggs
commented
Jul 11, 2023
| aws-ebs-csi-driver = { | ||
| service_account_role_arn = module.ebs_csi_driver_irsa.iam_role_arn | ||
| } | ||
| coredns = {} | ||
| kube-proxy = {} | ||
| coredns = { |
There was a problem hiding this comment.
standardized on this configuration across the board. Let me know if we want to tweak this and I can update. I think at minimum, keeping the preserve on the CNI is helpful for the examples
|
greens look nice! 🟢 |
5 tasks
vara-bonthu
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes