Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added a fix for Grafana to use sigv4 authentication #253

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: Added a fix for Grafana to use sigv4 authentication #253

merged 1 commit into from
Jul 17, 2023

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Jul 17, 2023 •
edited

What does this PR do?

馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Adds a new AMP datasource to Grafana datasources
  • Fixes issues related to authentication

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test July 17, 2023 19:58 — with GitHub Actions Inactive
askulkarni2
askulkarni2 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@askulkarni2 askulkarni2 merged commit e771f22 into main Jul 17, 2023
50 checks passed
@askulkarni2 askulkarni2 deleted the fix-amp branch July 17, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vara-bonthu @askulkarni2