Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger EMR on EKS jobs with Apache Airflow #39

Merged
merged 9 commits into from
Oct 9, 2022

Conversation

victorgu-github
Copy link
Contributor

@victorgu-github victorgu-github commented Oct 7, 2022

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR to add a new Add-on for Terraform EKS Blueprints repo (if applicable)
  • Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 7, 2022 21:47 Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 7, 2022 21:59 Inactive
@victorgu-github
Copy link
Contributor Author

@vara-bonthu the pre-commit failed because of the external modules not this example code. Pls review and I am ready to demo it.

@victorgu-github victorgu-github marked this pull request as ready for review October 8, 2022 02:44
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 8, 2022 04:13 Inactive
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great PR 👍🏼 @season1946 . Overall PR looks good to me. I left few minor comments.

schedulers/managed-airflow-mwaa/eks.tf Outdated Show resolved Hide resolved
schedulers/managed-airflow-mwaa/eks.tf Outdated Show resolved Hide resolved
schedulers/managed-airflow-mwaa/eks.tf Outdated Show resolved Hide resolved
schedulers/managed-airflow-mwaa/main.tf Outdated Show resolved Hide resolved
schedulers/managed-airflow-mwaa/variables.tf Outdated Show resolved Hide resolved
schedulers/managed-airflow-mwaa/variables.tf Outdated Show resolved Hide resolved
schedulers/managed-airflow-mwaa/eks.tf Outdated Show resolved Hide resolved
schedulers/managed-airflow-mwaa/eks.tf Show resolved Hide resolved
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 9, 2022 03:06 Inactive
@victorgu-github
Copy link
Contributor Author

@vara-bonthu thanks for the comments. they are all fixed in the new commit d5130dd

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@vara-bonthu vara-bonthu merged commit 171c0a2 into awslabs:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants