Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argo workflows on EKS example and doc #43

Merged
merged 23 commits into from
Oct 31, 2022
Merged

Argo workflows on EKS example and doc #43

merged 23 commits into from
Oct 31, 2022

Conversation

victorgu-github
Copy link
Contributor

@victorgu-github victorgu-github commented Oct 14, 2022 •
edited by vara-bonthu

What does this PR do?

Argo workflows on EKS example
#41

馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR to add a new Add-on for Terraform EKS Blueprints repo (if applicable)
  • Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 14, 2022 02:33 Inactive
@vara-bonthu vara-bonthu self-assigned this Oct 14, 2022
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 14, 2022 18:30 Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 25, 2022 02:23 Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 25, 2022 16:08 Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 25, 2022 20:51 Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 27, 2022 16:39 Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 28, 2022 20:32 Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 31, 2022 14:50 Inactive
vara-bonthu
vara-bonthu reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this PR Victor! It looks great apart form few minor comments.
I think it would be good if you could add this Argo Workflow addon to EKS Blueprints as an add-on and refer in this pattern.

schedulers/argo-workflow/addons.tf Outdated Show resolved Hide resolved
schedulers/argo-workflow/addons.tf Outdated Show resolved Hide resolved
schedulers/argo-workflow/addons.tf Outdated Show resolved Hide resolved
schedulers/argo-workflow/main.tf Outdated Show resolved Hide resolved
schedulers/argo-workflow/main.tf Outdated Show resolved Hide resolved
schedulers/argo-workflow/main.tf Outdated Show resolved Hide resolved
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 31, 2022 15:54 Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 31, 2022 16:43 Inactive
vara-bonthu
vara-bonthu reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments and then we are good for merge

schedulers/argo-workflow/locals.tf Outdated Show resolved Hide resolved
website/docs/job-schedulers-eks/argo-workflows-eks.md Show resolved Hide resolved
@victorgu-github victorgu-github temporarily deployed to DoEKS Test October 31, 2022 17:30 Inactive
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test October 31, 2022 19:10 Inactive
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test October 31, 2022 19:12 Inactive
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test October 31, 2022 19:24 Inactive
vara-bonthu
vara-bonthu approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vara-bonthu vara-bonthu merged commit aa26041 into awslabs:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vara-bonthu vara-bonthu vara-bonthu approved these changes

Assignees

@vara-bonthu vara-bonthu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@victorgu-github @vara-bonthu