Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove trailing curly from wildcard bucket arn #514

Merged
merged 1 commit into from
May 2, 2024

Conversation

dacort
Copy link
Contributor

@dacort dacort commented May 2, 2024

What does this PR do?

馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

The bucket arns for several aws_for_fluentbit addons have an extra } at the end, resulting in fluentbit unable to write logs to s3.

Motivation

鉂わ笍

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Collaborator

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah nice catch! Thank you for the PR!

@askulkarni2 askulkarni2 changed the title Remove trailing curly from wildcard bucket arn fix: Remove trailing curly from wildcard bucket arn May 2, 2024
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dacort Thanks for fixing the issue 馃憤馃徏 LGTM

@vara-bonthu vara-bonthu merged commit 1b59017 into awslabs:main May 2, 2024
54 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants