Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RayServe script name mismatch in Dockerfile #538

Merged
merged 1 commit into from
May 22, 2024

Conversation

charan-amzn
Copy link
Contributor

What does this PR do?

In Inference module, within Stable diffusion on GPU blueprint, RayServe FastAPI function is of different name than that of what's in pre-built image. So either file name for RayServe script has to be changed to that of what's in Docker image in Public ECR DoEKS repository or Dockerfile needs to be changed to reference right script name. This PR is intended to take latter approach in modifying Dockerfile, so users using blueprint will be able to build own image that references correct script

馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

Encountered error while following blueprint and hence identified the change necessary

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@charan-amzn charan-amzn changed the title Fixing RayServe script name mismatch in Dockerfile Fix-RayServe script name mismatch in Dockerfile May 21, 2024
@charan-amzn charan-amzn changed the title Fix-RayServe script name mismatch in Dockerfile fix: RayServe script name mismatch in Dockerfile May 21, 2024
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@vara-bonthu vara-bonthu merged commit fc3f20c into awslabs:main May 22, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants