Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC endpoints added;s3 state for e2e tests #77

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Dec 6, 2022

What does this PR do?

  1. E2E tests added for two patterns. More patterns will be added once the AWS limits are removed from AWS test account
  2. Added VPC endpoints as default for all the patterns. Enforcing best practise to our users
  3. Added commented s3 state for all versions.tf file to be used in End to End tests

Closes #65 #23

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR to add a new Add-on for Terraform EKS Blueprints repo (if applicable)
  • Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test December 6, 2022 23:27 — with GitHub Actions Inactive
@dalbhanj
Copy link
Contributor

dalbhanj commented Dec 7, 2022

lgtm

@victorgu-github
Copy link
Contributor

looks good to me.

@vara-bonthu vara-bonthu merged commit 210f27c into main Dec 8, 2022
@vara-bonthu vara-bonthu deleted the s3-state-for-e2e branch December 21, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[E2E Test] E2E test for all the blueprints
3 participants