Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] ACK EMR on EKS Controller pattern and example #81

Merged
merged 15 commits into from
Dec 16, 2022

Conversation

victorgu-github
Copy link
Contributor

@victorgu-github victorgu-github commented Dec 12, 2022

What does this PR do?

#51

馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR to add a new Add-on for Terraform EKS Blueprints repo (if applicable)
  • Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@victorgu-github victorgu-github temporarily deployed to DoEKS Test December 12, 2022 15:02 — with GitHub Actions Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test December 15, 2022 00:36 — with GitHub Actions Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test December 15, 2022 00:46 — with GitHub Actions Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test December 15, 2022 03:18 — with GitHub Actions Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test December 15, 2022 03:25 — with GitHub Actions Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test December 15, 2022 15:01 — with GitHub Actions Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test December 15, 2022 15:29 — with GitHub Actions Inactive
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @season1946 ! Few minor comments

analytics/terraform/emr-eks-ack-crossplane/addons.tf Outdated Show resolved Hide resolved
analytics/terraform/emr-eks-ack-crossplane/addons.tf Outdated Show resolved Hide resolved
analytics/terraform/emr-eks-ack-crossplane/data.tf Outdated Show resolved Hide resolved
analytics/terraform/emr-eks-karpenter/addons.tf Outdated Show resolved Hide resolved
analytics/terraform/emr-eks-karpenter/data.tf Show resolved Hide resolved
@victorgu-github victorgu-github temporarily deployed to DoEKS Test December 15, 2022 18:42 — with GitHub Actions Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test December 15, 2022 18:53 — with GitHub Actions Inactive
@vara-bonthu vara-bonthu temporarily deployed to DoEKS Test December 16, 2022 17:01 — with GitHub Actions Inactive
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @season1946 馃憤馃徏

@victorgu-github victorgu-github merged commit b76ae8d into awslabs:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants