Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] update argo workflows based on blog comments #89

Merged
merged 4 commits into from
Jan 4, 2023
Merged

[enhancement] update argo workflows based on blog comments #89

merged 4 commits into from
Jan 4, 2023

Conversation

victorgu-github
Copy link
Contributor

@victorgu-github victorgu-github commented Jan 3, 2023 •
edited

What does this PR do?

馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR to add a new Add-on for Terraform EKS Blueprints repo (if applicable)
  • Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@victorgu-github victorgu-github requested a review from a team as a code owner January 3, 2023 20:37
@victorgu-github victorgu-github temporarily deployed to DoEKS Test January 3, 2023 20:37 — with GitHub Actions Inactive
@victorgu-github victorgu-github temporarily deployed to DoEKS Test January 3, 2023 21:23 — with GitHub Actions Inactive
vara-bonthu
vara-bonthu requested changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments to address otherwise it's good 馃憤馃徏

schedulers/terraform/argo-workflow/helm-values/aws-for-fluentbit-values.yaml Outdated Show resolved Hide resolved
schedulers/terraform/argo-workflow/argo-events/sensor-sqs-sparkjobs.yaml Outdated Show resolved Hide resolved
schedulers/terraform/argo-workflow/argo-events/sensor-sqs-sparkjobs.yaml Outdated Show resolved Hide resolved
@victorgu-github victorgu-github temporarily deployed to DoEKS Test January 3, 2023 23:42 — with GitHub Actions Inactive
vara-bonthu
vara-bonthu reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more changes to be udpated

schedulers/terraform/argo-workflow/argo-events/sensor-sqs-sparkjobs.yaml Outdated Show resolved Hide resolved
schedulers/terraform/argo-workflow/argo-events/sensor-sqs-sparkjobs.yaml Outdated Show resolved Hide resolved
schedulers/terraform/argo-workflow/argo-events/sensor-sqs-sparkjobs.yaml Outdated Show resolved Hide resolved
@victorgu-github victorgu-github temporarily deployed to DoEKS Test January 4, 2023 00:03 — with GitHub Actions Inactive
@victorgu-github victorgu-github enabled auto-merge (squash) January 4, 2023 00:18
vara-bonthu
vara-bonthu approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 馃憤馃徏

@vara-bonthu vara-bonthu merged commit 4153816 into awslabs:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vara-bonthu vara-bonthu vara-bonthu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@victorgu-github @vara-bonthu