Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Opensearch construct #374

Merged
merged 32 commits into from
Feb 27, 2024
Merged

feat: Opensearch construct #374

merged 32 commits into from
Feb 27, 2024

Conversation

alexvt-amz
Copy link
Contributor

@alexvt-amz alexvt-amz commented Jan 24, 2024 •
edited by vgkowski
Loading

Issue #, if available:
#203

Description of changes:

Opensearch construct

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lmouhib lmouhib added the e2e-ready This PR is ready to be E2E-tested label Jan 24, 2024
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested e2e-completed The E2E tests have completed on this PR and removed e2e-ready This PR is ready to be E2E-tested e2e-testing This PR is currently being E2E-tested labels Jan 24, 2024
lmouhib
lmouhib requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@lmouhib lmouhib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move the construct under a new directory called consumption

@alexvt-amz
Copy link
Contributor Author

Can you please move the construct under a new directory called consumption

done

@sharp-pixel
Copy link

Can we rename Opensearch to OpenSearch?

@lmouhib lmouhib added e2e-ready This PR is ready to be E2E-tested and removed e2e-completed The E2E tests have completed on this PR labels Feb 7, 2024
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested e2e-completed The E2E tests have completed on this PR and removed e2e-ready This PR is ready to be E2E-tested e2e-testing This PR is currently being E2E-tested labels Feb 7, 2024
@lmouhib
Copy link
Contributor

lmouhib commented Feb 8, 2024

Can we rename Opensearch to OpenSearch?

@sharp-pixel where ? in the documentation? or Construct name? or everywhere where the uppercase is compliant?

@sharp-pixel
Copy link

Can we rename Opensearch to OpenSearch?

@sharp-pixel where ? in the documentation? or Construct name? or everywhere where the uppercase is compliant?

Everywhere where it doesn't break something.
Examples:

  • names: OpensearchNodes -> OpenSearchNodes
  • comments: Default Node Instances for Opensearch cluster -> Default Node Instances for OpenSearch cluster

@alexvt-amz
Copy link
Contributor Author

Can we rename Opensearch to OpenSearch?

@sharp-pixel where ? in the documentation? or Construct name? or everywhere where the uppercase is compliant?

Everywhere where it doesn't break something. Examples:

  • names: OpensearchNodes -> OpenSearchNodes
  • comments: Default Node Instances for Opensearch cluster -> Default Node Instances for OpenSearch cluster

Fixed

@vgkowski vgkowski mentioned this pull request Feb 12, 2024
Closed
@vgkowski vgkowski linked an issue Feb 12, 2024 that may be closed by this pull request
Provide an Amazon Opensearch construct with configuration helpers #203
Closed
vgkowski
vgkowski requested changes Feb 19, 2024
View reviewed changes
framework/src/consumption/lib/opensearch/opensearch-props.ts Outdated Show resolved Hide resolved
framework/src/consumption/lib/opensearch/opensearch-props.ts Outdated Show resolved Hide resolved
framework/src/consumption/lib/opensearch/opensearch-props.ts Show resolved Hide resolved
framework/src/consumption/lib/opensearch/opensearch-props.ts Outdated Show resolved Hide resolved
framework/src/consumption/lib/opensearch/opensearch.ts Outdated Show resolved Hide resolved
framework/test/unit/nag/consumption/nag-opensearch.test.ts Outdated Show resolved Hide resolved
framework/test/unit/nag/consumption/nag-opensearch.test.ts Outdated Show resolved Hide resolved
framework/test/unit/nag/consumption/nag-opensearch.test.ts Outdated Show resolved Hide resolved
website/docs/constructs/library/generated/_consumption-opensearch.mdx Outdated Show resolved Hide resolved
website/docs/constructs/library/generated/_consumption-opensearch.mdx Show resolved Hide resolved
@vgkowski vgkowski removed a link to an issue Feb 23, 2024
Provide an Amazon Opensearch construct with configuration helpers #203
Closed
@vgkowski vgkowski linked an issue Feb 23, 2024 that may be closed by this pull request
Provide an Amazon Opensearch construct with configuration helpers #203
Closed
lmouhib and others added 22 commits February 26, 2024 21:45
@lmouhib lmouhib merged commit 756a69e into main Feb 27, 2024
3 checks passed
@lmouhib lmouhib deleted the feat/opensearch2 branch February 27, 2024 18:23
@ajaykarpur ajaykarpur mentioned this pull request Mar 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmouhib lmouhib lmouhib approved these changes

@vgkowski vgkowski vgkowski approved these changes

Assignees
No one assigned
Labels
e2e-completed The E2E tests have completed on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide an Amazon Opensearch construct with configuration helpers
4 participants
@alexvt-amz @sharp-pixel @lmouhib @vgkowski