Feature/uniqueness row level results #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e columns with count() result in false
|
Note: Tests for |
Resolved this issue by not serializing the full column field in metrics for now |
rdsharma26
reviewed
Apr 27, 2023
| @@ -69,6 +71,10 @@ case class DoubleMetric( | |||
| extends Metric[Double] with FullColumn { | |||
|
|
|||
| override def flatten(): Seq[DoubleMetric] = Seq(this) | |||
|
|
|||
| override def getMetricWithoutFullColumn: DoubleMetric = { | |||
There was a problem hiding this comment.
Is this still required?
rdsharma26
reviewed
Apr 27, 2023
| @@ -513,7 +513,7 @@ private[deequ] object MetricSerializer extends JsonSerializer[Metric[_]] { | |||
| result.addProperty("instance", doubleMetric.instance) | |||
| result.addProperty("name", doubleMetric.name) | |||
| result.addProperty("value", doubleMetric.value.getOrElse(null).asInstanceOf[Double]) | |||
| doubleMetric.fullColumn.foreach(c => result.addProperty("fullColumn", c.expr.sql)) | |||
| // doubleMetric.fullColumn.foreach(c => result.addProperty("fullColumn", c.expr.sql)) | |||
There was a problem hiding this comment.
Maybe we can create an issue in Github as well and link it here?
src/main/scala/com/amazon/deequ/repository/fs/FileSystemMetricsRepository.scala
Outdated
Show resolved
Hide resolved
rdsharma26
approved these changes
Apr 27, 2023
rdsharma26
pushed a commit
that referenced
this pull request
Apr 27, 2023
- Added row-level results for Uniqueness - Modified tests to compare strings because comparisons involving the same columns with count() result in false - Remove serializing fullColumn for now
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
- Added row-level results for Uniqueness - Modified tests to compare strings because comparisons involving the same columns with count() result in false - Remove serializing fullColumn for now
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
- Added row-level results for Uniqueness - Modified tests to compare strings because comparisons involving the same columns with count() result in false - Remove serializing fullColumn for now
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
- Added row-level results for Uniqueness - Modified tests to compare strings because comparisons involving the same columns with count() result in false - Remove serializing fullColumn for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Building on this PR to add more analyzers that support row level results.
This PR adds row level results for the
Uniquenessanalyzer, which is used by several checks (isUnique,isPrimaryKey,hasUniqueness,uniqueValueRatio)Row level results for other
ScanShareableFrequencyBasedAnalyzerswill be added in a future PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.