Feature: Add Row Level Result Treatment Options for Miminum and Maximum #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eycho-am
changed the title
eycho-am
force-pushed
the
feature/rowLevelFilterMinMax
branch
from
ad7a8cc
to
6a3665e
Compare
rdsharma26
reviewed
Feb 21, 2024
Comment on lines
77
to
78
| case _ => | ||
| criterion |
There was a problem hiding this comment.
Can we add a comment here that we don't need special treatment for Null because that is the default behavior anyway when using where
| } | ||
| } | ||
|
|
||
| private def transformColForNullBehavior(col: Column, nullBehavior: NullBehavior): Column = { |
There was a problem hiding this comment.
Can we use column here directly instead of passing it in ascol ? In rowLevelResults, we use analyzerOptions directly instead of passing it in as a parameter.
| private[deequ] def rowLevelResults: Column = { | ||
| val filteredRowOutcome = getRowLevelFilterTreatment(analyzerOptions) | ||
| val whereNotCondition = where.map { expression => not(expr(expression)) } | ||
| val expression = when(regexp_extract(col(column), pattern.toString(), 0) =!= lit(""), 1) |
There was a problem hiding this comment.
Can we put when(regexp_extract(col(column), pattern.toString(), 0) =!= lit(""), 1) in a common place and reuse it in criterion and here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.