Column Count Analyzer and Check #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdsharma26
reviewed
Apr 10, 2024
| import com.amazon.deequ.metrics.Entity | ||
| import org.apache.spark.sql.DataFrame | ||
|
|
||
| case class ColumnCount(where: Option[String] = None) extends Analyzer[NumMatches, DoubleMetric] { |
There was a problem hiding this comment.
Can we remove where ? Or is that a requirement from Analyzer ?
Comment on lines
53
to
57
| if (state.isDefined) { | ||
| Analyzers.metricFromValue(state.get.metricValue(), name, instance, entity) | ||
| } else { | ||
| Analyzers.metricFromEmpty(this, name, instance, entity) | ||
| } |
There was a problem hiding this comment.
How about:
val metricValue = if(state.isDefined) state.get.metricValue() else this
Analyzers.metricFromEmpty(metricValue, name, instance, entity)
There was a problem hiding this comment.
it's Analyzers.metricFromValue if defined and Analyzers.metricFromEmpty otherwise so this won't work. I'll do a map though.
| @@ -26,6 +26,17 @@ import scala.util.Failure | |||
| import scala.util.Success | |||
| import scala.util.Try | |||
|
|
|||
| case class CustomSqlState(stateOrError: Either[Double, String]) extends DoubleValuedState[CustomSqlState] { | |||
There was a problem hiding this comment.
Either is right biased in Scala, which means the right sided value is what you would operate on when doing map or flatMap. In the case of storing exceptions or error messages, usually they are stored as the left sided value of the Either.
There was a problem hiding this comment.
I'm just moving this from Size.scala to its own class, I can address that in a different PR
shriyavanvari
approved these changes
Apr 15, 2024
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Fix flaky KLL test * Move CustomSql state to CustomSql analyzer * Implement new Analyzer to count columns * Improve documentation, remove unused parameter, replace if/else with map --------- Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Fix flaky KLL test * Move CustomSql state to CustomSql analyzer * Implement new Analyzer to count columns * Improve documentation, remove unused parameter, replace if/else with map --------- Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Fix flaky KLL test * Move CustomSql state to CustomSql analyzer * Implement new Analyzer to count columns * Improve documentation, remove unused parameter, replace if/else with map --------- Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Fix flaky KLL test * Move CustomSql state to CustomSql analyzer * Implement new Analyzer to count columns * Improve documentation, remove unused parameter, replace if/else with map --------- Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Fix flaky KLL test * Move CustomSql state to CustomSql analyzer * Implement new Analyzer to count columns * Improve documentation, remove unused parameter, replace if/else with map --------- Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
shriyavanvari
pushed a commit
that referenced
this pull request
May 2, 2024
* Fix flaky KLL test * Move CustomSql state to CustomSql analyzer * Implement new Analyzer to count columns * Improve documentation, remove unused parameter, replace if/else with map --------- Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
shriyavanvari
pushed a commit
that referenced
this pull request
May 2, 2024
* Fix flaky KLL test * Move CustomSql state to CustomSql analyzer * Implement new Analyzer to count columns * Improve documentation, remove unused parameter, replace if/else with map --------- Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This adds a dataset-scope analyzer that counts the number of columns in a dataset, and uses the analyzer in a Deequ Check
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.