Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional specification of instance name in CustomSQL analyzer metric. #569

Merged
merged 1 commit into from
May 24, 2024

Conversation

tylermcdaniel0
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

  • Allow (but do not require) specification of metric instance name in CustomSQL analyzer.
  • This will allow users to more easily distinguish success metrics produced by multiple distinct CustomSQL statements within a VerificationSuite.

@tylermcdaniel0 tylermcdaniel0 marked this pull request as draft May 24, 2024 13:03
@tylermcdaniel0 tylermcdaniel0 force-pushed the customsql-analyzer-metric-instance branch from 9cf2c6d to 963ceba Compare May 24, 2024 13:05
@tylermcdaniel0 tylermcdaniel0 marked this pull request as ready for review May 24, 2024 13:06
@tylermcdaniel0 tylermcdaniel0 force-pushed the customsql-analyzer-metric-instance branch from 963ceba to 0b143c8 Compare May 24, 2024 14:58
Copy link
Contributor

@rdsharma26 rdsharma26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tylermcdaniel0 tylermcdaniel0 merged commit 116f63f into master May 24, 2024
1 check passed
eycho-am pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants