more detailed Applicability results / add metric to ConstraintResult / scoverage #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 15, 2018 10:30
…straints in CheckResult.constraintResults
sscdotopen
suggested changes
Nov 16, 2018
src/main/scala/com/amazon/deequ/analyzers/applicability/Applicability.scala
Outdated
Show resolved
Hide resolved
| val constraintApplicabilities = check.constraints.zip(namedMetrics).map { | ||
| case (constraint, (_, metric)) => | ||
| constraint -> metric.isSuccess | ||
| }.toMap |
There was a problem hiding this comment.
.toMap should be on the next line
There was a problem hiding this comment.
Still haven't lost hope for myself that I'll learn deequ style :)
Do you think we could have a rule for it in our style check?
There was a problem hiding this comment.
We tried to configure such rules, unfortunately, there is always an edge case that is not coverable by the stylechecker...
src/main/scala/com/amazon/deequ/analyzers/applicability/Applicability.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/amazon/deequ/constraints/AnalysisBasedConstraint.scala
Show resolved
Hide resolved
sscdotopen
approved these changes
Nov 20, 2018
|
@stefan-grafberger Thank you for having a look the changes! |
sscdotopen
pushed a commit
that referenced
this pull request
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
ConstraintResultinCheckResultis now linked to the metric that the constraint evaluation was based onApplicability.isApplicable(check)now contains all constraints and their applicabilitiesmvn scoverage:report, https://github.com/scoverage/scoverage-maven-plugin)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.