This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
fix: update status correctly when posting in a bundle #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carvantes
approved these changes
Feb 28, 2022
carvantes
added a commit
that referenced
this pull request
Mar 3, 2022
* feat: implement getActiveSubscriptions (#131) * feat: set Subscription status from requested to active on save (#132) * fix: fix multi-tenant query for getActiveSubscriptions * fix: properly update subscriptionStatus on update or delete (#135) * remove log statement * fix: update status correctly when posting in a bundle (#139) * fix: fix undefined object property (#140) * bump interface version * fix: fix unit tests Co-authored-by: Sukeerth Vegaraju <ssvegaraju@yahoo.co.in> Co-authored-by: Yanyu Zheng <yz2690@columbia.edu>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixed a statement that was ignoring any subscriptions that were created as part of a bundle and not setting the status to active.
Tested by POSTing a bundle with subscriptions and retrieving those subscriptions to ensure that the
statuswas correctly set toactive.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.