Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: add alias for new and existing index #83

Merged
merged 3 commits into from
Jun 10, 2021
Merged

Conversation

Bingjiling
Copy link
Contributor

@Bingjiling Bingjiling commented Jun 8, 2021

Issue #, if available:

Description of changes:

  • Add alias for new and existing index on update/create
  • Use alias for update/create
  • Tested for
    • Alias is created for existing index upon update/create
    • New index is created with alias
    • Create, update and delete patient using index alias

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@carvantes carvantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but I left a comment that needs to be addressed before merging.

Also, we need to make a change to write to aliases instead of indexes at:

Otherwise the aliases are meaningless.

src/ddbToEs/ddbToEsHelper.ts Outdated Show resolved Hide resolved
src/ddbToEs/ddbToEsHelper.ts Show resolved Hide resolved
src/ddbToEs/ddbToEsHelper.test.ts Show resolved Hide resolved
@Bingjiling Bingjiling requested a review from carvantes June 9, 2021 17:22
@Bingjiling Bingjiling merged commit af637d4 into mainline Jun 10, 2021
@Bingjiling Bingjiling deleted the index-alias branch June 10, 2021 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants