Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: persistence change for group export #98

Merged
merged 3 commits into from
Aug 2, 2021

Conversation

Bingjiling
Copy link
Contributor

@Bingjiling Bingjiling commented Jul 28, 2021

Issue #, if available:

Description of changes:

  • Update to persistence to pass in parameters needed for group export
  • Reject request if user ask for resource type outside of allowed types
  • Clean up export request before saving to DDB
  • Unit test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added size/m and removed size/s labels Jul 29, 2021
@Bingjiling Bingjiling changed the title [WIP] feat: persistence change for group export feat: persistence change for group export Jul 29, 2021
Copy link
Contributor

@rsmayda rsmayda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! For the glue script could we use a set for 'types' instead of a list? Not sure if that part has already been handled

@Bingjiling
Copy link
Contributor Author

Overall looks good! For the glue script could we use a set for 'types' instead of a list? Not sure if that part has already been handled

Yes! Types are used as a set in the Glue script, it's handled inside the script here

@Bingjiling Bingjiling merged commit ec2da63 into feat-multitenancy Aug 2, 2021
@Bingjiling Bingjiling deleted the group-export branch August 2, 2021 19:20
carvantes added a commit that referenced this pull request Aug 17, 2021
* feat: Add multi tenancy to S3 binary resource(#87)

* feat: tenant isolation for DDB CRUD operations (#86)

* feat: update ddbToEs to handle multi-tenant records (#91)

* feat: Multi tenancy bulk export (#90)

* fix: list bulk export files with tenant prefix (#94)

* feat: persistence change for group export (#98)

* feat: enable hard delete in Elasticsearch (#100)


Co-authored-by: zheyanyu <zheyanyu@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants