This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
feat: support update as create in bundle service #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen trying to lock resources for 'updates'
carvantes
reviewed
May 26, 2021
Comment on lines
193
to
194
| // allow for update as create scenario | ||
| if (itemResponse instanceof ResourceNotFoundError && itemsToLock[i].operation !== 'update') { |
There was a problem hiding this comment.
I think that this works, but it will inadvertently enable update as crate for all customers using bundles/transactions.
DynamoDbDataService has a parameter supportUpdateCreate that enables update as create for the regular update operation but doesn't address bundles/transactions. I think that we can pass down that same parameter to DynamoDbBundleService and use it to conditionally apply your changes.
There was a problem hiding this comment.
I just added the supportUpdateCreate flag to dynamoDbBundleService.ts. Creating a test seems not so trivial. I'll give it a shot.
added 2 commits
May 26, 2021 12:26
…to true in constructor.
…hir-works-on-aws-persistence-ddb into allow_update_as_create
rsmayda
reviewed
May 26, 2021
rsmayda
reviewed
May 26, 2021
… update as create.
rsmayda
reviewed
May 28, 2021
rsmayda
reviewed
May 28, 2021
rsmayda
reviewed
May 28, 2021
rsmayda
reviewed
May 28, 2021
rsmayda
approved these changes
May 31, 2021
carvantes
approved these changes
Jun 1, 2021
carvantes
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In order to lock resources for operations other than 'create' the latest version ID needs to be looked up first.
If the resource isn't found a ResourceNotFoundError is thrown.
With this change only ResourceNotFoundErrors for operations other than 'update' are being counted and result in a failed transaction.
By allowing 'update' operation for resources that don't exist in dynamo yet using update as create is possible.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.