Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(construct): Support for bedrock guardrail #473

Merged
merged 20 commits into from
May 31, 2024
Merged

Conversation

dineshSajwan
Copy link
Contributor

@dineshSajwan dineshSajwan commented May 22, 2024

Fixes #469

  1. Create bedrock guardrail and guardrail version.
  2. Add Content filters , Denied topics, Word filters and Sensitive information filters to the guardrail.
  3. Update cdk to latest version (2.143) and update resources following updates in L1 constructs (feat: update L1 CloudFormation resource definitions aws/aws-cdk#30182)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Signed-off-by: github-actions <github-actions@github.com>
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 81.44476% with 131 lines in your changes are missing coverage. Please review.

Project coverage is 92.54%. Comparing base (716c6e1) to head (2a9ec31).

Files Patch % Lines
src/cdk-lib/bedrock/topic-list.ts 55.28% 55 Missing ⚠️
src/cdk-lib/bedrock/guardrails.ts 81.33% 42 Missing ⚠️
src/cdk-lib/bedrock/content-policy.ts 80.88% 26 Missing ⚠️
src/cdk-lib/bedrock/guardrail-version.ts 86.48% 5 Missing ⚠️
src/cdk-lib/bedrock/pii-list.ts 97.97% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   92.98%   92.54%   -0.44%     
==========================================
  Files          47       52       +5     
  Lines       11255    11950     +695     
  Branches      363      427      +64     
==========================================
+ Hits        10465    11059     +594     
- Misses        790      891     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dineshSajwan dineshSajwan marked this pull request as ready for review May 23, 2024 19:40
@dineshSajwan dineshSajwan requested a review from a team as a code owner May 23, 2024 19:40
@krokoko
Copy link
Collaborator

krokoko commented May 28, 2024

Few comments:

krokoko and others added 5 commits May 28, 2024 16:59
@krokoko
Copy link
Collaborator

krokoko commented May 28, 2024

Remaining tasks:

  • test the features
  • update documentation

@krokoko krokoko enabled auto-merge (squash) May 30, 2024 20:20
Copy link
Collaborator

@krokoko krokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some testing in both Ts and Python and haven't faced any issue

Copy link
Contributor

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some broken checks. Overall LGTM

@krokoko krokoko merged commit ae7a3ad into main May 31, 2024
16 of 18 checks passed
@krokoko krokoko deleted the feat/bedrock_guardrail branch May 31, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bedrock): add support for guardrails
4 participants