-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce Titan Text Embedding V2 #495
Conversation
Bedrock KB supports `amazon.titan-embed-text-v2:0`. Signed-off-by: ./c² <cagataycali@icloud.com>
Hi @cagataycali thank you for this PR, did you try to deploy a KB with this model ? |
Looks like while deploying CDK we're having a regexp error.
|
I just checked with the cfn team and this is a know issue, I will close this PR for now and provide an update when a fix is available. Will update the related issue as well. |
update model name since vector dimension cannot be configured yet Signed-off-by: Alain Krok <alkrok@amazon.com>
The underlying issue has been fixed, reopening this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 53 53
Lines 12562 12565 +3
Branches 436 436
=======================================
+ Hits 11591 11594 +3
Misses 971 971 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for confirmation to require a contributor statement
Knowledge Bases for Bedrock supports
amazon.titan-embed-text-v2:0
.Fixes #492
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.