Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce Titan Text Embedding V2 #495

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Conversation

cagataycali
Copy link
Contributor

@cagataycali cagataycali commented Jun 5, 2024

Knowledge Bases for Bedrock supports amazon.titan-embed-text-v2:0.

Fixes #492


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Bedrock KB supports `amazon.titan-embed-text-v2:0`.

Signed-off-by: ./c² <cagataycali@icloud.com>
@krokoko
Copy link
Collaborator

krokoko commented Jun 5, 2024

Hi @cagataycali thank you for this PR, did you try to deploy a KB with this model ?

@cagataycali
Copy link
Contributor Author

Looks like while deploying CDK we're having a regexp error.

Properties validation failed for resource :: with message:
[#/KnowledgeBaseConfiguration/VectorKnowledgeBaseConfiguration/EmbeddingModelArn: string [arn:aws:bedrock:us-east-1::foundation-model/amazon.titan-embed-text-v2:0] does not match pattern ^arn:aws(-[^:]+)?:bedrock:[a-z0-9-]{1,20}:(([0-9]{12}:custom-model
/[a-z0-9-]{1,63}[.]{1}[a-z0-9-]{1,63}/[a-z0-9]{12})|(:foundation-model/[a-z0-9-]{1,63}[.]{1}[a-z0-9-]{1,63}))$]

@krokoko
Copy link
Collaborator

krokoko commented Jun 5, 2024

I just checked with the cfn team and this is a know issue, I will close this PR for now and provide an update when a fix is available. Will update the related issue as well.

@krokoko krokoko closed this Jun 5, 2024
@krokoko krokoko mentioned this pull request Jun 5, 2024
2 tasks
@krokoko krokoko reopened this Jun 17, 2024
update model name since vector dimension cannot be configured yet

Signed-off-by: Alain Krok <alkrok@amazon.com>
krokoko
krokoko previously approved these changes Jun 17, 2024
@krokoko
Copy link
Collaborator

krokoko commented Jun 17, 2024

The underlying issue has been fixed, reopening this PR

@krokoko krokoko enabled auto-merge (squash) June 17, 2024 16:44
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (879aa53) to head (e58c606).

Current head e58c606 differs from pull request most recent head 7833264

Please upload reports for the commit 7833264 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files          53       53           
  Lines       12562    12565    +3     
  Branches      436      436           
=======================================
+ Hits        11591    11594    +3     
  Misses        971      971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottschreckengaust scottschreckengaust changed the title Introduce Titan Text Embedding V2 feat: Introduce Titan Text Embedding V2 Jun 17, 2024
Copy link
Collaborator

@scottschreckengaust scottschreckengaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for confirmation to require a contributor statement

@krokoko krokoko merged commit 6b7f813 into awslabs:main Jun 17, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bedrock): (Add TITAN_EMBED_TEXT_V2)
4 participants