Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and modernize git-coco #5

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Improve and modernize git-coco #5

merged 3 commits into from
Nov 1, 2021

Conversation

rkeene
Copy link
Contributor

@rkeene rkeene commented Oct 29, 2021

Description of changes:

git-coco has a few rough edges which can be cleaned up.

This changeset improves them:

  • Quoting appropriately
  • Use file descriptor 2 instead of /dev/stderr for writing error messages
  • Make usage checks more explicit
  • For function-local variables, mark them appropriately

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ryansonshine
Copy link

PR is draft but is ready to go after the merge of #4

@ryansonshine ryansonshine mentioned this pull request Oct 30, 2021
Merged
@rkeene rkeene marked this pull request as ready for review November 1, 2021 15:53
stilvoid
stilvoid approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@stilvoid stilvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you :)

@stilvoid stilvoid merged commit 6972637 into awslabs:master Nov 1, 2021
@rkeene rkeene deleted the feature/bash-updates branch November 1, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stilvoid stilvoid stilvoid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rkeene @ryansonshine @stilvoid