Fix for pre-commit hook failure on bash 4 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the issue described here. awslabs#45 (comment)
divolenchai
approved these changes
Dec 3, 2017
|
I think there's more work that should be done (like reusing the git_grep function or removing it), but I'll go ahead and merge this until we have a more automated way to test bash 4. |
|
Is there any possibility of adding a new release to incorporate this (and presumably other) features? I just added the latest release to nixpkgs, but hadn't noticed it was nearly 2 years old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described here.
#45 (comment)