Added paper code examples as tests #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-123/1 is complete. |
lostella
previously approved these changes
Jun 18, 2019
aalexandrov
previously approved these changes
Jun 18, 2019
| ) | ||
|
|
||
|
|
||
| def test_arxiv_example(): |
There was a problem hiding this comment.
The names are a bit misleading. It's probably better to have something like test_listing_1 and test_appendix_c.
There was a problem hiding this comment.
Yeah, the icml and arxiv listings 1 are the same, but I guess we cannot update the ICML paper anyway once the proceedings a published. Renamed.
mbohlkeschneider
dismissed stale reviews from aalexandrov and lostella
via
64919b7
|
Job PR-123/2 is complete. |
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 79.05% 79.01% -0.04%
==========================================
Files 110 110
Lines 6301 6305 +4
==========================================
+ Hits 4981 4982 +1
- Misses 1320 1323 +3
|
lostella
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added paper code examples from the arxiv paper as tests. If these break, we need to update the arxiv paper code examples. One caveat is that the tests do not pull and run electricity because it takes too long. So if this line changes, the example would still break. But we should be able to catch a lot of other API changes this way.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.