Export torch models in torch module directly.
#2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaheba
changed the title
torch module directly.
lostella
reviewed
Feb 23, 2023
| __path__ = extend_path(__path__, __name__) # type: ignore | ||
| from .model.deep_npts import DeepNPTSEstimator | ||
| from .model.deepar import DeepAREstimator | ||
| from .model.mqf2 import MQF2MultiHorizonEstimator |
There was a problem hiding this comment.
This line adds a dependency on cpflows which I’m not sure we want to require at this level. See https://github.com/awslabs/gluonts/blob/dev/requirements/requirements-extras-cpflows.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to imports model more easily, e.g.:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup