Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-dir-entries to zip file creation to prune empty directories #73

Merged
merged 2 commits into from Jun 5, 2019

Conversation

jgasthaus
Copy link
Contributor

Issue #, if available:

Addresses #66

Description of changes:

Disable the creating of directory entries in the zip file (which then omits empty directories as a side effect).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@szha
Copy link
Member

szha commented Jun 5, 2019

Job PR-73/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-73/1/index.html

@alexw91
Copy link
Member

alexw91 commented Jun 5, 2019

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #73   +/-   ##
======================================
  Coverage    78.6%   78.6%           
======================================
  Files         110     110           
  Lines        6278    6278           
======================================
  Hits         4935    4935           
  Misses       1343    1343

@lostella
Copy link
Contributor

lostella commented Jun 5, 2019

Now it looks right, thanks!

@szha
Copy link
Member

szha commented Jun 5, 2019

Job PR-73/2 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-73/2/index.html

@jgasthaus jgasthaus merged commit 430385c into awslabs:master Jun 5, 2019
@jgasthaus jgasthaus deleted the zip_file branch June 5, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants