Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix artificial dataset bug #83

Merged
merged 3 commits into from Jun 6, 2019

Conversation

benidis
Copy link
Contributor

@benidis benidis commented Jun 6, 2019

Fix issue #82

The hour and minute random values were out of bound since the random.Random.randint(low, high) gives samples with the limits inclusive (numpy does not).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@szha
Copy link
Member

szha commented Jun 6, 2019

Job PR-83/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-83/1/index.html

@alexw91
Copy link
Member

alexw91 commented Jun 6, 2019

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files         110      110           
  Lines        6282     6282           
=======================================
  Hits         4940     4940           
  Misses       1342     1342
Impacted Files Coverage Δ
src/gluonts/distribution/binned.py 94.87% <ø> (ø) ⬆️
src/gluonts/dataset/artificial/_base.py 32.16% <0%> (ø) ⬆️

@szha
Copy link
Member

szha commented Jun 6, 2019

Job PR-83/2 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-83/2/index.html

@szha
Copy link
Member

szha commented Jun 6, 2019

Job PR-83/3 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-83/3/index.html

@benidis benidis merged commit d7e73ec into awslabs:master Jun 6, 2019
@benidis benidis deleted the fix_artificial_dataset_bug branch June 11, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants