Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): AWS::CDK::Metadata resource should be automatically generated #421

Merged
merged 3 commits into from
Jan 18, 2022
Merged

fix(schema): AWS::CDK::Metadata resource should be automatically generated #421

merged 3 commits into from
Jan 18, 2022

Commits on Jan 18, 2022

  1. fix(schema): AWS::CDK::Metadata should be generated 

    In PR awslabs#418, the AWS::CDK::Metadata was kindly added, however the
resource was manually created, which lead to it being overwritten when
`go generate` was run to update the goformation schema from
CloudFormation/SAM specifications.

This change adds a new `generate/cdk.json` file that contains a manually
crafted version of the AWS::CDK::* specification (as I don't think an
automatically published one exists), and automatically generates the
`cdk/aws-cdk-metadata.go` resource from it.

One side effect of this is that the `AWS::CDK::Metadata` resource is no
longer in the main `cloudformation.schema.json` that some IDEs use for
autocompletion/intellisense, and it now lives in an autogenerated
`schema/cdk.schema.json` file (similar to how SAM is separate, as it's
generated from a separate resource definition file).
    @PaulMaddox
    PaulMaddox committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    8b6e5fd View commit details
    Browse the repository at this point in the history

  2. Separate commit for generated CDK files

    @PaulMaddox
    PaulMaddox committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    ed495cd View commit details
    Browse the repository at this point in the history

  3. Separate commit for all other CloudFormation updates

    @PaulMaddox
    PaulMaddox committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    d605daa View commit details
    Browse the repository at this point in the history