Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify the correctness of GraphStorm input config. #20

Closed
zheng-da opened this issue Mar 11, 2023 · 0 comments
Closed

Verify the correctness of GraphStorm input config. #20

zheng-da opened this issue Mar 11, 2023 · 0 comments
Assignees
@classicsong
Labels
v0.2

Comments

@zheng-da
Copy link
Contributor

zheng-da commented Mar 11, 2023 •
edited
Loading

  • Don't require users to provide graph name.
  • Verify the node/edge feature names and label names.
  • If infer_data.test_idxs is empty, return an error in the inference script.
  • We may want to warn users if they want to have mini-batch inference. (mini-batch inference on a large graph can take very long time).
@classicsong classicsong self-assigned this Mar 30, 2023
@zheng-da zheng-da added the v0.1 label Apr 4, 2023
@classicsong classicsong mentioned this issue Apr 4, 2023
Closed
10 tasks
@classicsong classicsong mentioned this issue Apr 12, 2023
Merged
classicsong added a commit that referenced this issue Apr 12, 2023
@classicsong
BugFix: evaluation_frequency needs to work with save_model_per_iters …
3d51789 
…set to -1 (#84)

By default save_model_per_iters is set to -1 which means GFS will not
save models within an epoch. In this case, evaluation_frequency should
be able to use any positive integer.

#20 

*Description of changes:*
Fix the bug


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

Co-authored-by: Xiang Song <xiangsx@amazon.com>
@classicsong classicsong added v0.1.1 and removed v0.1 labels May 20, 2023
@zheng-da zheng-da added v0.2 and removed v0.1.1 labels Jun 25, 2023
@zheng-da zheng-da mentioned this issue Jul 10, 2023
Merged
zheng-da added a commit that referenced this issue Jul 18, 2023
@zheng-da
add checks to verify the correctness of the input arguments (#317)
063fd75 
*Description of changes:*
We need to verify the correctness of the input arguments as early as
possible. This is important when we deal with large datasets.
#20

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

---------

Co-authored-by: Ubuntu <ubuntu@ip-172-31-12-121.us-west-2.compute.internal>
Co-authored-by: Ubuntu <ubuntu@ip-172-31-10-98.us-west-2.compute.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@classicsong classicsong

Labels
v0.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zheng-da @classicsong