Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gsf.py to make the code of creating decoders and creating link prediction dataloders reusable. #825

Merged
merged 4 commits into from
May 6, 2024

Conversation

classicsong
Copy link
Contributor

Issue #, if available:
Related to #789

Description of changes:

  1. decouple the code of creating decoders from the code of creating built-in models to make the code of creating decoders more reusable.
  2. add get_builtin_lp_train_dataloader_class and get_builtin_lp_eval_dataloader_class in gsf.py

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@classicsong classicsong requested a review from zhjwy9343 May 6, 2024 18:57
@classicsong classicsong added 0.3 ready able to trigger the CI labels May 6, 2024
Copy link
Contributor

@zhjwy9343 zhjwy9343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/graphstorm/gsf.py Show resolved Hide resolved
@classicsong classicsong merged commit f0b949c into awslabs:main May 6, 2024
6 checks passed
@classicsong classicsong deleted the refactor-builtin-model-init branch May 6, 2024 22:39
thvasilo pushed a commit to thvasilo/graphstorm that referenced this pull request May 17, 2024
…nk prediction dataloders reusable. (awslabs#825)

*Issue #, if available:*
Related to awslabs#789 

*Description of changes:*
1. decouple the code of creating decoders from the code of creating
built-in models to make the code of creating decoders more reusable.
2. add `get_builtin_lp_train_dataloader_class` and
`get_builtin_lp_eval_dataloader_class` in gsf.py


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

---------

Co-authored-by: Xiang Song <xiangsx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.3 ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants