feat: customizable resolutions #23
Conversation
NorbertNader
requested review from
fpauer,
boweihan,
diehbria and
gareth-amazon
NorbertNader
force-pushed
the
customizable-resolutions
branch
3 times, most recently
from
5a9173f
to
78661d9
Compare
* added customizable resolutions for sitewise data source which means we can specify a resolution per asset property * refactored resolutionMapping to resolution and allowed to pass string if we want a specific resolution for all queries
NorbertNader
force-pushed
the
customizable-resolutions
branch
from
01ed950
to
ecdfeb6
Compare
packages/core/src/data-sources/site-wise/client/getAggregatedPropertyDataPoints.ts
Show resolved
Hide resolved
| let defaultResolutionDataQueries: SiteWiseAssetDataStreamQuery | undefined; | ||
|
|
||
| query.assets.forEach(({ assetId, properties }) => { | ||
| let aggregatedDataProperties: PropertyQuery[] | undefined; |
There was a problem hiding this comment.
you can remove if conditions by defining the type as an Array only and in the line 87 just add to the array instead of initializing it.
There was a problem hiding this comment.
I would rather be specific of the shape of the array and keep it as PropertyQuery type or just undefined to keep it consistent with the return type. This was my first approach though but I ran into type errors like
TS7034: Variable 'aggregatedDataProperties' implicitly has type 'any[]' in some locations where its type cannot be determined.
There was a problem hiding this comment.
But if you defined an array of type PropertyQuery you should not get any ts error. I would rather reduce if conditions.
There was a problem hiding this comment.
If I define an array of the PropertyQuery it would have to be like { propertyId: '' } since we don't have any properties yet.
There was a problem hiding this comment.
you can just have an empty array.
There was a problem hiding this comment.
You are right, we can just initialize them as empty array.
- Save/Loading Works - Fixed issues with Compatibility with Enhanced Edit Feature - SubModels are compatbile with any tool that operates on an object 3D Co-authored-by: Mitchell Lee <mitchlee@amazon.com>
* added customizable resolutions for sitewise data source which means we can specify a resolution per asset property * refactored resolutionMapping to resolution and allowed to pass string if we want a specific resolution for all queries Co-authored-by: Norbert Nader <nnader@amazon.com>
Overview
feat: customizable resolutions
Tests
https://github.com/awslabs/iot-app-kit/runs/4597925804?check_suite_focus=true
Legal
This project is available under the Apache 2.0 License.