feat: request data in descending order #30
Conversation
NorbertNader
requested review from
fpauer,
boweihan,
diehbria and
gareth-amazon
| @@ -62,10 +62,13 @@ export const dataReducer: Reducer<DataStreamsStore, AsyncActions> = ( | |||
| // TODO: clean this to one single source of truth cache | |||
| const requestCache = streamStore != null ? streamStore.requestCache : EMPTY_CACHE; | |||
|
|
|||
| // We always want data in ascending order in the cache | |||
| const sortedData = getDataPoints(data, data.resolution).sort((a, b) => a.x - b.x); | |||
There was a problem hiding this comment.
we always want it in order in the cache, but I think we should also always keep them in order in the DataStream. Could we instead solve this more towards the service layer, so that the reducer instead can remain unchanged and not need to sort? It should instead be the job of the 'SiteWise data source' to call the success handler with the data in the correct order if possible
There was a problem hiding this comment.
Yeah I was actually considering that as well. I didn't go down that route to create a "pit of success" and instead make sure that data will always be in ascending order, now matter what order it comes in from the service layer. What I am worried about is how we can enforce the data to be sorted. Why do you think it is better to sort it at the service layer?
Co-authored-by: Norbert Nader <nnader@amazon.com>
Overview
Before
After
Tests
Updated unit tests
Legal
This project is available under the Apache 2.0 License.