Fix setTimeout error #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehbria
approved these changes
Jan 12, 2022
sheilaXu
pushed a commit
that referenced
this pull request
Sep 23, 2022
…nchor is clicked (#32) * SceneViewer anchor will only send a 'change' event when the current anchor is clicked * Only turn off anchor highlight if current selected anchor was highlighted. Fixed unit test. * Updated code coverage
TheEvilDev
pushed a commit
that referenced
this pull request
Nov 2, 2022
Replace setTimeout in flaky test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replaces a setTimeout with a call from inside the interval loop. Its not a real use-case but its not likely to break now wither.
Tests
ran UTs
Legal
This project is available under the Apache 2.0 License.