fix: require npm >=8.7.0 to fix yarn.lock issue with d3-color-1-fix #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpopv
requested review from
NorbertNader,
sheilaXu,
boweihan,
square-li,
tjuranek,
corteggiano,
chejimmy,
dpportet and
diehbria
dpportet
approved these changes
Nov 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
@sheilaXu identified an issue where
"d3-color-1-fix"is sometimes not properly referenced in package-lock.json. I tested with different versions of npm and verified that this is an issue with versions below 8.7, likely due to this npm bug with setting overrides in package-lock.Here I am bumping the minimum version of npm for the package to 8.7, which ensures consistent package-lock generation.
Legal
This project is available under the Apache 2.0 License.