fix(composer): Fix camera view positioning under sub model #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumanity
previously approved these changes
Nov 10, 2022
packages/scene-composer/src/components/toolbars/floatingToolbar/items/AddObjectMenu.tsx
Outdated
Show resolved
Hide resolved
jwills-jdubs
force-pushed
the
camera-view-submodel-positioning
branch
from
cd49fa9
to
1ae084e
Compare
jwills-jdubs
force-pushed
the
camera-view-submodel-positioning
branch
from
37642bd
to
432a256
Compare
mumanity
approved these changes
Nov 10, 2022
jwills-jdubs
changed the title
jwills-jdubs
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Camera's do not get the right positioning when placed on a SubModelRef. This fix uses the non-submodel space for a sub model while maintaining hierarchical placement
Legal
This project is available under the Apache 2.0 License.