fix(composer): Fixes the light helper delete #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity link 1. Reverts the previous change to parent to an dobject as this causes an error on delete thanks to React Three Fiber based removal 2. Helper checks each frame whether or not it should remain visible based on the ancestry of the light
sheilaXu
approved these changes
Nov 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
useFramegets a bad wrap as the boogeyman but this look up the ancestor tree should not cause performance issues but maintains a simplicity and code cleanliness to get around this issue. Typically only a complex set of calculations would be problematic but most 3D software performs operations every frame. Should we see performance issues we can revisit the implementationLegal
This project is available under the Apache 2.0 License.