Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(composer): drag root node crashes scene #372

Merged
merged 1 commit into from
Nov 16, 2022
Merged

fix(composer): drag root node crashes scene #372

merged 1 commit into from
Nov 16, 2022

Conversation

sheilaXu
Copy link
Contributor

Overview

fix the scene crash when:

  1. drag a root node and drop it as a child of another node
  2. delete the node moved
  3. reload the scene and see crash (null was saved as one of the root node index)

Legal

This project is available under the Apache 2.0 License.

@sheilaXu sheilaXu marked this pull request as ready for review November 16, 2022 04:27
@jwills-jdubs jwills-jdubs merged commit ca01c40 into main Nov 16, 2022
@jwills-jdubs jwills-jdubs deleted the fix-scene-crash branch November 16, 2022 07:22
@github-actions github-actions bot mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwills-jdubs jwills-jdubs jwills-jdubs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sheilaXu @jwills-jdubs