Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor Site Wise Asset session interface to support Promises #40

Merged
merged 6 commits into from
Jan 31, 2022

Conversation

gareth-amazon
Copy link
Contributor

Overview

  • Refactor to expose a Promise based interface for getting assets
  • Also split up the "query" style interface into discrete methods

Tests

[Include a link to the passing GitHub action running the test suite here.]

Legal

This project is available under the Apache 2.0 License.

@gareth-amazon gareth-amazon merged commit d309262 into main Jan 31, 2022
@diehbria diehbria deleted the feat_assets_interface_refactor branch May 5, 2022 16:27
sheilaXu pushed a commit that referenced this pull request Sep 23, 2022
TheEvilDev pushed a commit that referenced this pull request Nov 2, 2022
…40)

break up the query style interface into individual method calls with unique signatures. Add methods that return a Promise.
This was referenced Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants